]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ip_gre: fix wrong return value of erspan_rcv
authorHaishuang Yan <yanhaishuang@cmss.chinamobile.com>
Fri, 15 Dec 2017 02:46:16 +0000 (10:46 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Dec 2017 19:10:39 +0000 (14:10 -0500)
If pskb_may_pull return failed, return PACKET_REJECT instead of -ENOMEM.

Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
Cc: William Tu <u9012063@gmail.com>
Signed-off-by: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Acked-by: William Tu <u9012063@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_gre.c

index bb6239169b1ab943a6418494dab5018843bcde3c..9c1735632c8c43cc0607d54403571362895d91e2 100644 (file)
@@ -266,7 +266,7 @@ static int erspan_rcv(struct sk_buff *skb, struct tnl_ptk_info *tpi,
        len = gre_hdr_len + sizeof(*ershdr);
 
        if (unlikely(!pskb_may_pull(skb, len)))
-               return -ENOMEM;
+               return PACKET_REJECT;
 
        iph = ip_hdr(skb);
        ershdr = (struct erspanhdr *)(skb->data + gre_hdr_len);