]> git.proxmox.com Git - pmg-gui.git/commitdiff
jslint: if needs a block
authorDominik Csapak <d.csapak@proxmox.com>
Mon, 23 Oct 2017 13:01:12 +0000 (15:01 +0200)
committerDietmar Maurer <dietmar@proxmox.com>
Mon, 23 Oct 2017 15:30:58 +0000 (17:30 +0200)
single statements after if can be confusing

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
js/ClusterAdministration.js
js/LoginView.js
js/PostfixMailQueue.js
js/PostfixQShape.js
js/StatStore.js
js/SystemConfiguration.js
js/UserBlackWhiteList.js
js/ViewMailHeaders.js

index d1a2ff38b4be5e82f3a7462fbd739cfd5a787c68..f59c1013743142307c2d1f5372bacc3b2a72bea6 100644 (file)
@@ -247,7 +247,9 @@ Ext.define('PMG.ClusterAdministration', {
                    renderer: function(value, metaData, record) {
                        var d = record.data;
                        var state = 'active';
-                       if (!d.insync) state = 'syncing';
+                       if (!d.insync) {
+                           state = 'syncing';
+                       }
                        if (d.conn_error) {
                            metaData.tdCls = 'x-form-invalid-field';
                            var html = '<p>' +  Ext.htmlEncode(d.conn_error) + '</p>';
index 7de8082687ce77e2b1dee1bb16a457a896e820ba..af2e80a0d98d74060b644feae0053cf93fd777e8 100644 (file)
@@ -11,7 +11,9 @@ Ext.define('PMG.LoginView', {
 
            var realmfield = me.lookup('realmfield');
 
-           if (view.targetview !== 'quarantineview') return;
+           if (view.targetview !== 'quarantineview') {
+               return;
+           }
 
            realmfield.setValue('quarantine');
 
index d757309fce6270ce01a4227a01e9a73c230f6e39..101a43b91b36a0e1fe723e64c9a807dc969a5f06 100644 (file)
@@ -32,7 +32,9 @@ Ext.define('PMG.Postfix.MailQueue', {
        xclass: 'Ext.app.ViewController',
 
        init: function(view) {
-           if (view.nodename) view.setNodename(view.nodename);
+           if (view.nodename) {
+               view.setNodename(view.nodename);
+           }
 
            view.delayFilterTask = new Ext.util.DelayedTask(function() {
                var filter = view.lookupReference('filter').getValue();
@@ -170,7 +172,9 @@ Ext.define('PMG.Postfix.MailQueue', {
     updateProxy: function() {
        var me = this;
 
-       if (me.pendingLoad) return;
+       if (me.pendingLoad) {
+           return;
+       }
 
        var proxy = {
            type: 'proxmox',
index 2f0b073c1443b36d77d5fdb75d98bb5bfa46eae9..3fa88aeabefe2a049fa05883561b04350051f6c6 100644 (file)
@@ -34,7 +34,9 @@ Ext.define('PMG.Postfix.QShape', {
        xclass: 'Ext.app.ViewController',
 
        init: function(view) {
-           if (view.nodename) view.setNodename(view.nodename);
+           if (view.nodename) {
+               view.setNodename(view.nodename);
+           }
        },
 
        onFlush: function() {
index ec837805544e5c67800a779d2c9cbf1c1e099858..a5e94e96bd02324496fd2fecac7c1c1a344ea7bd 100644 (file)
@@ -33,8 +33,9 @@ Ext.define('PMG.data.StatStore', {
 
        var last = me.proxy.extraParams;
 
-       if (last.starttime === ts.starttime && last.endtime === ts.endtime)
+       if (last.starttime === ts.starttime && last.endtime === ts.endtime) {
            return; // avoid repeated loads
+       }
 
        me.proxy.url = me.staturl;
        me.proxy.extraParams = { starttime: ts.starttime, endtime: ts.endtime };
index 741d54b9db75b021852ebc6df6dd1c610bdae53d..2c816fe28aa29f6663c59eb87d15b6c4014dafbc 100644 (file)
@@ -15,7 +15,9 @@ Ext.define('PMG.RestoreSystemConfiguration', {
                gettext('Confirm'),
                gettext('Reset rule database to factory defaults?'),
                function(button) {
-                   if (button !== 'yes') return;
+                   if (button !== 'yes') {
+                       return;
+                   }
                    var url = '/config/ruledb';
                    Proxmox.Utils.API2Request({
                        url: '/config/ruledb',
index 7255b6b0ca5355a05d7231d4a34036156d58769d..523bd17fd559e16984c8781500c1d4ed18b0831a 100644 (file)
@@ -65,7 +65,9 @@ Ext.define('PMG.UserBlackWhiteList', {
        onRemoveAddress: function() {
            var me = this.getView();
            var rec = me.selModel.getSelection()[0];
-           if (!rec) return;
+           if (!rec) {
+               return;
+           }
 
            var params = me.getStore().getProxy().getExtraParams() || {};
            var url = '/quarantine/' + me.listname + '/' + rec.getId();
index c4059f2fa9c494e035acbb5a23faf69fe0855aef..f3cd4ba5f8e69f7481edd84909ac9654c9ab034e 100644 (file)
@@ -34,11 +34,17 @@ Ext.define('PMG.ViewMailHeaders', {
                success: function(response, opts) {
                    var data = response.result.data;
                    var from = data.match(/^FROM:\s*(.*\S)\s*$/mi);
-                   if (from) view.lookupReference('fromField').setValue(from[1]);
+                   if (from) {
+                       view.lookupReference('fromField').setValue(from[1]);
+                   }
                    var to = data.match(/^TO:\s*(.*\S)\s*$/mi);
-                   if (to) view.lookupReference('toField').setValue(to[1]);
+                   if (to) {
+                       view.lookupReference('toField').setValue(to[1]);
+                   }
                    var subject = data.match(/^SUBJECT:\s*(.*\S)\s*$/mi);
-                   if (subject) view.lookupReference('subjectField').setValue(subject[1]);
+                   if (subject) {
+                       view.lookupReference('subjectField').setValue(subject[1]);
+                   }
                    panel.update(Ext.String.htmlEncode(data));
                },
                failure: function (response, opts) {