]> git.proxmox.com Git - mirror_frr.git/commitdiff
pbrd: Fix memory leak in json output
authorDonald Sharp <sharpd@nvidia.com>
Wed, 4 Nov 2020 14:11:13 +0000 (09:11 -0500)
committerDonald Sharp <sharpd@nvidia.com>
Wed, 4 Nov 2020 14:11:13 +0000 (09:11 -0500)
Fix a memory leak in using some pbr json commands.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
pbrd/pbr_vty.c

index eb51516c24418eefbaec80028ca4b53acc8c1676..26163dcc56de3e5fdfb7d3f7c3058f9e2330978f 100644 (file)
@@ -907,16 +907,22 @@ DEFPY (show_pbr_interface,
                        if (j)
                                this_iface = json_object_new_object();
 
-                       if (!ifp->info)
+                       if (!ifp->info) {
+                               json_object_free(this_iface);
                                continue;
+                       }
 
-                       if (name && strcmp(ifp->name, name) != 0)
+                       if (name && strcmp(ifp->name, name) != 0) {
+                               json_object_free(this_iface);
                                continue;
+                       }
 
                        pbr_ifp = ifp->info;
 
-                       if (strcmp(pbr_ifp->mapname, "") == 0)
+                       if (strcmp(pbr_ifp->mapname, "") == 0) {
+                               json_object_free(this_iface);
                                continue;
+                       }
 
                        pbrm = pbrm_find(pbr_ifp->mapname);