]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/s390x: Hard code size with MO_{8|16|32|64}
authorTony Nguyen <tony.nguyen@bt.com>
Fri, 23 Aug 2019 18:36:49 +0000 (04:36 +1000)
committerRichard Henderson <richard.henderson@linaro.org>
Tue, 3 Sep 2019 15:30:39 +0000 (08:30 -0700)
Temporarily no-op size_memop was introduced to aid the conversion of
memory_region_dispatch_{read|write} operand "unsigned size" into
"MemOp op".

Now size_memop is implemented, again hard coded size but with
MO_{8|16|32|64}. This is more expressive and avoids size_memop calls.

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <76dc97273a8eb5e10170ffc16526863df808f487.1566466906.git.tony.nguyen@bt.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
hw/s390x/s390-pci-inst.c

index 0c958fc3910bfa1b00906b4796a46b66100769f0..0e92a372cad83736468b20fae1f3eac3c2d837c5 100644 (file)
@@ -782,8 +782,7 @@ int pcistb_service_call(S390CPU *cpu, uint8_t r1, uint8_t r3, uint64_t gaddr,
     for (i = 0; i < len / 8; i++) {
         result = memory_region_dispatch_write(mr, offset + i * 8,
                                               ldq_p(buffer + i * 8),
-                                              size_memop(8),
-                                              MEMTXATTRS_UNSPECIFIED);
+                                              MO_64, MEMTXATTRS_UNSPECIFIED);
         if (result != MEMTX_OK) {
             s390_program_interrupt(env, PGM_OPERAND, 6, ra);
             return 0;