media: wl128x: Fix an error code in fm_download_firmware()

BugLink: https://bugs.launchpad.net/bugs/1863019
[ Upstream commit ef4bb63dc1f7213c08e13f6943c69cd27f69e4a3 ]

We forgot to set "ret" on this error path.

Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c
index 1cf4019689a566fd39bd20505b9034dd8269311a..cccf1a743f4e61df6e62445bb3e1f8d1eeeb5415 100644 (file)
--- a/drivers/media/radio/wl128x/fmdrv_common.c
+++ b/drivers/media/radio/wl128x/fmdrv_common.c
@@ -1271,8 +1271,9 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
                switch (action->type) {
                case ACTION_SEND_COMMAND:       /* Send */
-                       if (fmc_send_cmd(fmdev, 0, 0, action->data,
-                                               action->size, NULL, NULL))
+                       ret = fmc_send_cmd(fmdev, 0, 0, action->data,
+                                          action->size, NULL, NULL);
+                       if (ret)
                                goto rel_fw;
 
                        cmd_cnt++;