]> git.proxmox.com Git - mirror_qemu.git/commitdiff
hw/block/pflash_cfi02: Document 'Page Mode' operations are not supported
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Sat, 18 May 2019 18:23:31 +0000 (20:23 +0200)
committerPhilippe Mathieu-Daudé <philmd@redhat.com>
Tue, 2 Jul 2019 00:31:13 +0000 (02:31 +0200)
The 'page mode' feature entry was implicitly set as zero
(not supported). Document it exists, so we won't discard
it if we squeeze the CFI table.

Signed-off-by: Stephen Checkoway <stephen.checkoway@oberlin.edu>
Message-Id: <20190426162624.55977-6-stephen.checkoway@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[PMD: Extracted from bigger patch]
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
hw/block/pflash_cfi02.c

index 23d05a6308c4c53a5089a51d186fa9c9171d1501..01d9c5d75a0e01493f4f9c941ad251d35276ea3d 100644 (file)
@@ -637,7 +637,9 @@ static void pflash_cfi02_realize(DeviceState *dev, Error **errp)
     pfl->cfi_table[0x0a + pri_ofs] = 0x00;
     /* Burst mode not supported. */
     pfl->cfi_table[0x0b + pri_ofs] = 0x00;
-    assert(0x0b + pri_ofs < ARRAY_SIZE(pfl->cfi_table));
+    /* Page mode not supported. */
+    pfl->cfi_table[0x0c + pri_ofs] = 0x00;
+    assert(0x0c + pri_ofs < ARRAY_SIZE(pfl->cfi_table));
 }
 
 static Property pflash_cfi02_properties[] = {