]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
i40e/virtchnl: fix application of sizeof to pointer
authorGustavo A R Silva <garsilva@embeddedor.com>
Wed, 18 Oct 2017 20:34:25 +0000 (15:34 -0500)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 27 Nov 2017 21:50:35 +0000 (13:50 -0800)
sizeof when applied to a pointer typed expression gives the size of
the pointer.

The proper fix in this particular case is to code sizeof(*vfres)
instead of sizeof(vfres).

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A R Silva <garsilva@embeddedor.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

index a3dc9b93294651064eabcadd469763bd3f93f1cc..36cb8e068e856b321ae426b4eb0e1953330790aa 100644 (file)
@@ -2086,7 +2086,7 @@ static int i40e_vc_request_queues_msg(struct i40e_vf *vf, u8 *msg, int msglen)
        }
 
        return i40e_vc_send_msg_to_vf(vf, VIRTCHNL_OP_REQUEST_QUEUES, 0,
-                                     (u8 *)vfres, sizeof(vfres));
+                                     (u8 *)vfres, sizeof(*vfres));
 }
 
 /**