]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net/mlx5e: fix TLS dependency
authorArnd Bergmann <arnd@arndb.de>
Fri, 25 May 2018 21:36:06 +0000 (23:36 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 May 2018 14:03:40 +0000 (10:03 -0400)
With CONFIG_TLS=m and MLX5_CORE_EN=y, we get a link failure:

drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In function `mlx5e_tls_handle_ooo':
tls_rxtx.c:(.text+0x24c): undefined reference to `tls_get_record'
drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.o: In function `mlx5e_tls_handle_tx_skb':
tls_rxtx.c:(.text+0x9a8): undefined reference to `tls_device_sk_destruct'

This narrows down the dependency to only allow the configurations
that will actually work. The existing dependency on TLS_DEVICE is
not sufficient here since MLX5_EN_TLS is a 'bool' symbol.

Fixes: c83294b9efa5 ("net/mlx5e: TLS, Add Innova TLS TX support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Acked-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/Kconfig

index ee6684779d112478ee4061960f1cf24fd918560f..2545296a0c087888701048dfd36b957cb91c6993 100644 (file)
@@ -91,6 +91,7 @@ config MLX5_EN_TLS
        bool "TLS cryptography-offload accelaration"
        depends on MLX5_CORE_EN
        depends on TLS_DEVICE
+       depends on TLS=y || MLX5_CORE=m
        depends on MLX5_ACCEL
        default n
        ---help---