watchfrr: change some messages from errors to info

When watchfrr starts up, it first tries to connect to daemons. This is
expected to fail if we are just starting up FRR, but we log it as an
error, and it shows up red in journalctl. Similarly when we fork
background commands that is also logged as an error. This is scaring
users, let's change these to info.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

diff --git a/watchfrr/watchfrr.c b/watchfrr/watchfrr.c
index ed9616963dad19d96851a1170e0aac29826d6e03..05e6651229a709867d9e81c6eb8b3e86697aba1c 100644 (file)
--- a/watchfrr/watchfrr.c
+++ b/watchfrr/watchfrr.c
@@ -318,9 +318,8 @@ static pid_t run_background(char *shell_cmd)
                }
        default:
                /* Parent process: we will reap the child later. */
-               flog_err_sys(EC_LIB_SYSTEM_CALL,
-                            "Forked background command [pid %d]: %s",
-                            (int)child, shell_cmd);
+               zlog_info("Forked background command [pid %d]: %s", (int)child,
+                         shell_cmd);
                return child;
        }
 }
@@ -559,9 +558,9 @@ static int wakeup_init(struct thread *t_wakeup)
 
        dmn->t_wakeup = NULL;
        if (try_connect(dmn) < 0) {
-               flog_err(EC_WATCHFRR_CONNECTION,
-                        "%s state -> down : initial connection attempt failed",
-                        dmn->name);
+               zlog_info(
+                       "%s state -> down : initial connection attempt failed",
+                       dmn->name);
                dmn->state = DAEMON_DOWN;
        }
        phase_check();