]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
target: Move a declaration of a global variable into a header file
authorBart Van Assche <bart.vanassche@wdc.com>
Tue, 31 Oct 2017 18:03:09 +0000 (11:03 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Sat, 4 Nov 2017 22:15:30 +0000 (15:15 -0700)
This patch avoids that sparse reports the following warning:

drivers/target/target_core_configfs.c:2267:33: warning: symbol 'target_core_dev_item_ops' was not declared. Should it be static?

Fixes: c17cd24959cd ("target/configfs: Kill se_device->dev_link_magic")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Mike Christie <mchristi@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_fabric_configfs.c
drivers/target/target_core_internal.h

index e9e917cc6441913326316e75cc42dab99cf353c3..e1416b007aa43e0dcbd40d3b4d5e720c42e355c4 100644 (file)
@@ -623,8 +623,6 @@ static struct configfs_attribute *target_fabric_port_attrs[] = {
        NULL,
 };
 
-extern struct configfs_item_operations target_core_dev_item_ops;
-
 static int target_fabric_port_link(
        struct config_item *lun_ci,
        struct config_item *se_dev_ci)
index f30e8ac13386dc3c58ae30e8e8072cd56547652f..2c5004ffb581a84be9febf073bdecc5687f4fa18 100644 (file)
@@ -88,6 +88,7 @@ int   target_for_each_device(int (*fn)(struct se_device *dev, void *data),
                               void *data);
 
 /* target_core_configfs.c */
+extern struct configfs_item_operations target_core_dev_item_ops;
 void   target_setup_backend_cits(struct target_backend *);
 
 /* target_core_fabric_configfs.c */