]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
UBUNTU: SAUCE: {topost} net: hns3: using modulo for cyclic counters in hclge_cmd_send
authorHuazhong Tan <tanhuazhong@huawei.com>
Wed, 18 Apr 2018 02:55:46 +0000 (10:55 +0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 6 Jun 2018 18:41:49 +0000 (14:41 -0400)
BugLink: https://bugs.launchpad.net/bugs/1768670
There are some codes in hclge_cmd.c which can be simplified by
used %= operator.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

index 0839e8410e6dcce526f35a0f258e574720c0ffcc..28556a98908316d2170e623d854f826c7f05b161 100644 (file)
@@ -228,8 +228,7 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
                desc_to_use = &hw->cmq.csq.desc[hw->cmq.csq.next_to_use];
                *desc_to_use = desc[handle];
                (hw->cmq.csq.next_to_use)++;
-               if (hw->cmq.csq.next_to_use == hw->cmq.csq.desc_num)
-                       hw->cmq.csq.next_to_use = 0;
+               hw->cmq.csq.next_to_use %= hw->cmq.csq.desc_num;
                handle++;
        }
 
@@ -269,8 +268,7 @@ int hclge_cmd_send(struct hclge_hw *hw, struct hclge_desc *desc, int num)
                        hw->cmq.last_status = desc_ret;
                        ntc++;
                        handle++;
-                       if (ntc == hw->cmq.csq.desc_num)
-                               ntc = 0;
+                       ntc %= hw->cmq.csq.desc_num;
                }
        }