]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
perf callchain: Fixup help/config for no-unwinding
authorRabin Vincent <rabinv@axis.com>
Wed, 10 Aug 2016 13:52:28 +0000 (15:52 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 8 Nov 2016 01:13:47 +0000 (22:13 -0300)
Since 841e3558b2d ("perf callchain: Recording 'dwarf' callchains do not
need DWARF unwinding support"), --call-graph dwarf is allowed in 'perf
record' even without unwind support.  A couple of other places don't
reflect this yet though: the help text should list dwarf as a valid
record mode and the dump_size config should be respected too.

Signed-off-by: Rabin Vincent <rabinv@axis.com>
Cc: He Kuang <hekuang@huawei.com>
Fixes: 841e3558b2de ("perf callchain: Recording 'dwarf' callchains do not need DWARF unwinding support")
Link: http://lkml.kernel.org/r/1470837148-7642-1-git-send-email-rabin.vincent@axis.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/callchain.c
tools/perf/util/callchain.h

index 07fd30bc2f816feeda146fe98343f5ce408884e8..ae58b493af4549d07558b9b730b9cc7f05759a7e 100644 (file)
@@ -193,7 +193,6 @@ int perf_callchain_config(const char *var, const char *value)
 
        if (!strcmp(var, "record-mode"))
                return parse_callchain_record_opt(value, &callchain_param);
-#ifdef HAVE_DWARF_UNWIND_SUPPORT
        if (!strcmp(var, "dump-size")) {
                unsigned long size = 0;
                int ret;
@@ -203,7 +202,6 @@ int perf_callchain_config(const char *var, const char *value)
 
                return ret;
        }
-#endif
        if (!strcmp(var, "print-type"))
                return parse_callchain_mode(value);
        if (!strcmp(var, "order"))
index 13e75549c4407dcf750c52e123ce3d48cc57ed2c..47cfd10809755f9f2ed3dfd9fdd5b13b46ad9330 100644 (file)
 
 #define CALLCHAIN_HELP "setup and enables call-graph (stack chain/backtrace):\n\n"
 
-#ifdef HAVE_DWARF_UNWIND_SUPPORT
 # define RECORD_MODE_HELP  HELP_PAD "record_mode:\tcall graph recording mode (fp|dwarf|lbr)\n"
-#else
-# define RECORD_MODE_HELP  HELP_PAD "record_mode:\tcall graph recording mode (fp|lbr)\n"
-#endif
 
 #define RECORD_SIZE_HELP                                               \
        HELP_PAD "record_size:\tif record_mode is 'dwarf', max size of stack recording (<bytes>)\n" \