]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
i2c: designware: Discard Cherry Trail model flag
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Thu, 28 May 2020 09:33:17 +0000 (12:33 +0300)
committerWolfram Sang <wsa@kernel.org>
Sat, 30 May 2020 09:33:54 +0000 (11:33 +0200)
A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed
since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C
bus pm_disabled workaround"), but the flag most likely by mistake has been
left in the Dw I2C drivers. Let's remove it. Since MODEL_MSCC_OCELOT is
the only model-flag left, redefine it to be 0x100 so setting a very first
bit in the MODEL_MASK bits range.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-designware-core.h
drivers/i2c/busses/i2c-designware-pcidrv.c
drivers/i2c/busses/i2c-designware-platdrv.c

index 150de5e5c31bd3e3fff924815447951191660202..b9ef9b0deef0d75267800a38714d9d4ef7894182 100644 (file)
@@ -289,8 +289,7 @@ struct dw_i2c_dev {
 #define ACCESS_INTR_MASK       0x00000004
 #define ACCESS_NO_IRQ_SUSPEND  0x00000008
 
-#define MODEL_CHERRYTRAIL      0x00000100
-#define MODEL_MSCC_OCELOT      0x00000200
+#define MODEL_MSCC_OCELOT      0x00000100
 #define MODEL_MASK             0x00000f00
 
 u32 dw_readl(struct dw_i2c_dev *dev, int offset);
index 11a5e4751eab719b5ee436b73f525442bca6be59..947c096f86e37fcf05df692e9262733bc756aa27 100644 (file)
@@ -149,7 +149,6 @@ static struct dw_pci_controller dw_pci_controllers[] = {
        },
        [cherrytrail] = {
                .bus_num = -1,
-               .flags = MODEL_CHERRYTRAIL,
                .scl_sda_cfg = &byt_config,
        },
        [elkhartlake] = {
index f6d2c96e35cef6ff8a33d7c9129c295a352c79fe..ca057aa9eac4c14be1b3d7d9f94d19ea35517374 100644 (file)
@@ -44,7 +44,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
        { "INT3432", 0 },
        { "INT3433", 0 },
        { "80860F41", ACCESS_NO_IRQ_SUSPEND },
-       { "808622C1", ACCESS_NO_IRQ_SUSPEND | MODEL_CHERRYTRAIL },
+       { "808622C1", ACCESS_NO_IRQ_SUSPEND },
        { "AMD0010", ACCESS_INTR_MASK },
        { "AMDI0010", ACCESS_INTR_MASK },
        { "AMDI0510", 0 },