net/sched: sch_qfq: use extack on errors messages

Some error messages are still being printed to dmesg.
Since extack is available, provide error messages there.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index 02098a02943eb90a67cce829b26a4cf9b79e545c..abcc4808783135327afb798ec562cad2c5277c4d 100644 (file)
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -402,8 +402,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
        int err;
        int delta_w;
 
-       if (tca[TCA_OPTIONS] == NULL) {
-               pr_notice("qfq: no options\n");
+       if (NL_REQ_ATTR_CHECK(extack, NULL, tca, TCA_OPTIONS)) {
+               NL_SET_ERR_MSG_MOD(extack, "missing options");
                return -EINVAL;
        }
 
@@ -442,8 +442,9 @@ static int qfq_change_class(struct Qdisc *sch, u32 classid, u32 parentid,
        delta_w = weight - (cl ? cl->agg->class_weight : 0);
 
        if (q->wsum + delta_w > QFQ_MAX_WSUM) {
-               pr_notice("qfq: total weight out of range (%d + %u)\n",
-                         delta_w, q->wsum);
+               NL_SET_ERR_MSG_FMT_MOD(extack,
+                                      "total weight out of range (%d + %u)\n",
+                                      delta_w, q->wsum);
                return -EINVAL;
        }