]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
ASoC: Intel: Atom: sst-atom-controls: remove redundant assignments
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 13 Aug 2020 20:01:27 +0000 (15:01 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 18 Aug 2020 10:50:08 +0000 (11:50 +0100)
cppcheck complains of a possible NULL pointer dereference but setting
a pointer before using list_for_each_entry() is not useful.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813200147.61990-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/atom/sst-atom-controls.c

index ff42f629b03538559fa9495c5235515503193efe..6b5a34a15acb856fb57dfd2de5a65e4f228bdc6a 100644 (file)
@@ -299,7 +299,7 @@ static int sst_find_and_send_pipe_algo(struct sst_data *drv,
 {
        int ret = 0;
        struct sst_algo_control *bc;
-       struct sst_module *algo = NULL;
+       struct sst_module *algo;
 
        dev_dbg(&drv->pdev->dev, "Enter: widget=%s\n", pipe);
 
@@ -602,7 +602,7 @@ static int sst_set_pipe_gain(struct sst_ids *ids,
        int ret = 0;
        struct sst_gain_mixer_control *mc;
        struct sst_gain_value *gv;
-       struct sst_module *gain = NULL;
+       struct sst_module *gain;
 
        list_for_each_entry(gain, &ids->gain_list, node) {
                struct snd_kcontrol *kctl = gain->kctl;