scsi: qla2xxx: Remove unnecessary NULL check

The list iterator can't be NULL so this check is not required.  Removing
the check silences a Smatch warning about inconsistent NULL checking.

    drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show()
    error: we previously assumed 'fcport' could be null (see line 372)

Link: https://lore.kernel.org/r/YAkaaSrhn1mFqyHy@mwanda
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index ccce0eab844edc0a4266ecf2dfc970fa06686b21..85bd0e468d43edaff3610ad40f0fc6bea4bbc924 100644 (file)
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -369,7 +369,7 @@ qla_dfs_tgt_counters_show(struct seq_file *s, void *unused)
        seq_puts(s, "\n");
 
        list_for_each_entry(fcport, &vha->vp_fcports, list) {
-               if (!fcport || !fcport->rport)
+               if (!fcport->rport)
                        continue;
 
                seq_printf(s, "Target Num = %7d Link Down Count = %14lld\n",