ubifs: Fix error return code in ubifs_init_authentication()

BugLink: https://bugs.launchpad.net/bugs/1910822
[ Upstream commit 3cded66330591cfd2554a3fd5edca8859ea365a2 ]

Fix to return PTR_ERR() error code from the error handling case where
ubifs_hash_get_desc() failed instead of 0 in ubifs_init_authentication(),
as done elsewhere in this function.

Fixes: 49525e5eecca5 ("ubifs: Add helper functions for authentication support")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>

diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
index f985a3fbbb36a15e202a7b31c80dff518b5651cf..b10418b5fb719e5667e26d3c089242f7aaa45ae9 100644 (file)
--- a/fs/ubifs/auth.c
+++ b/fs/ubifs/auth.c
@@ -352,8 +352,10 @@ int ubifs_init_authentication(struct ubifs_info *c)
        c->authenticated = true;
 
        c->log_hash = ubifs_hash_get_desc(c);
-       if (IS_ERR(c->log_hash))
+       if (IS_ERR(c->log_hash)) {
+               err = PTR_ERR(c->log_hash);
                goto out_free_hmac;
+       }
 
        err = 0;