]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
tipc: checking for NULL instead of IS_ERR()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 18 Oct 2017 07:48:25 +0000 (10:48 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Oct 2017 07:34:00 +0000 (08:34 +0100)
The tipc_alloc_conn() function never returns NULL, it returns error
pointers, so I have fixed the check.

Fixes: 14c04493cb77 ("tipc: add ability to order and receive topology events in driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/server.c

index 713077536d0cedb2fe904576640e64b61f0f6fb4..acaef80fb88cfca4ea569a003f52ca04a3e2f577 100644 (file)
@@ -504,7 +504,7 @@ bool tipc_topsrv_kern_subscr(struct net *net, u32 port, u32 type,
        *(u32 *)&sub.usr_handle = port;
 
        con = tipc_alloc_conn(tipc_topsrv(net));
-       if (!con)
+       if (IS_ERR(con))
                return false;
 
        *conid = con->conid;