]> git.proxmox.com Git - mirror_qemu.git/commitdiff
qapi/block-core: add doc describing GlusterServer vs. SocketAddress
authorPrasanna Kumar Kalever <prasanna.kalever@redhat.com>
Sat, 20 Aug 2016 17:58:44 +0000 (23:28 +0530)
committerJeff Cody <jcody@redhat.com>
Tue, 13 Sep 2016 05:34:55 +0000 (01:34 -0400)
Added documentation describing relation between GlusterServer and
SocketAddress qapi schemas.

Thanks to Markus Armbruster <armbru@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Message-id: 1471715924-3642-1-git-send-email-prasanna.kalever@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
qapi/block-core.json

index 59128f7f89decb64752fc4926ba2ee88664e3574..173fb08ea3e72390f7d9d786e15fa7edc6dae267 100644 (file)
 #
 # @tcp:        host address and port number
 #
+# This is similar to SocketAddress, only distinction:
+#
+# 1. GlusterServer is a flat union, SocketAddress is a simple union.
+#    A flat union is nicer than simple because it avoids nesting
+#    (i.e. more {}) on the wire.
+#
+# 2. GlusterServer lacks case 'fd', since gluster doesn't let you
+#    pass in a file descriptor.
+#
+# GlusterServer is actually not Gluster-specific, its a
+# compatibility evolved into an alternate for SocketAddress.
+#
 # Since: 2.7
 ##
 { 'union': 'GlusterServer',