]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
nfc: st-nci: remove unnecessary labels
authorwengjianfeng <wengjianfeng@yulong.com>
Wed, 26 May 2021 01:16:24 +0000 (09:16 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 26 May 2021 20:10:04 +0000 (13:10 -0700)
Some labels are only used once, so we delete them and use the
return statement instead of the goto statement.

Signed-off-by: wengjianfeng <wengjianfeng@yulong.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210526011624.11204-1-samirweng1979@163.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/st-nci/vendor_cmds.c

index c6a9d30a4dba4cdef9b02dad78688833c6462e80..94b600029a2a029195af4439176a2380b2c30b57 100644 (file)
@@ -98,7 +98,7 @@ static int st_nci_hci_dm_get_info(struct nfc_dev *dev, void *data,
        r = nci_hci_send_cmd(ndev, ST_NCI_DEVICE_MGNT_GATE, ST_NCI_HCI_DM_GETINFO,
                             data, data_len, &skb);
        if (r)
-               goto exit;
+               return r;
 
        msg = nfc_vendor_cmd_alloc_reply_skb(dev, ST_NCI_VENDOR_OUI,
                                             HCI_DM_GET_INFO, skb->len);
@@ -117,7 +117,6 @@ static int st_nci_hci_dm_get_info(struct nfc_dev *dev, void *data,
 
 free_skb:
        kfree_skb(skb);
-exit:
        return r;
 }
 
@@ -131,7 +130,7 @@ static int st_nci_hci_dm_get_data(struct nfc_dev *dev, void *data,
        r = nci_hci_send_cmd(ndev, ST_NCI_DEVICE_MGNT_GATE, ST_NCI_HCI_DM_GETDATA,
                             data, data_len, &skb);
        if (r)
-               goto exit;
+               return r;
 
        msg = nfc_vendor_cmd_alloc_reply_skb(dev, ST_NCI_VENDOR_OUI,
                                             HCI_DM_GET_DATA, skb->len);
@@ -150,7 +149,6 @@ static int st_nci_hci_dm_get_data(struct nfc_dev *dev, void *data,
 
 free_skb:
        kfree_skb(skb);
-exit:
        return r;
 }
 
@@ -216,7 +214,7 @@ static int st_nci_hci_get_param(struct nfc_dev *dev, void *data,
 
        r = nci_hci_get_param(ndev, param->gate, param->data, &skb);
        if (r)
-               goto exit;
+               return r;
 
        msg = nfc_vendor_cmd_alloc_reply_skb(dev, ST_NCI_VENDOR_OUI,
                                             HCI_GET_PARAM, skb->len);
@@ -235,7 +233,6 @@ static int st_nci_hci_get_param(struct nfc_dev *dev, void *data,
 
 free_skb:
        kfree_skb(skb);
-exit:
        return r;
 }
 
@@ -262,7 +259,7 @@ static int st_nci_hci_dm_vdc_measurement_value(struct nfc_dev *dev, void *data,
                             ST_NCI_HCI_DM_VDC_MEASUREMENT_VALUE,
                             data, data_len, &skb);
        if (r)
-               goto exit;
+               return r;
 
        msg = nfc_vendor_cmd_alloc_reply_skb(dev, ST_NCI_VENDOR_OUI,
                                HCI_DM_VDC_MEASUREMENT_VALUE, skb->len);
@@ -281,7 +278,6 @@ static int st_nci_hci_dm_vdc_measurement_value(struct nfc_dev *dev, void *data,
 
 free_skb:
        kfree_skb(skb);
-exit:
        return r;
 }
 
@@ -299,7 +295,7 @@ static int st_nci_hci_dm_vdc_value_comparison(struct nfc_dev *dev, void *data,
                             ST_NCI_HCI_DM_VDC_VALUE_COMPARISON,
                             data, data_len, &skb);
        if (r)
-               goto exit;
+               return r;
 
        msg = nfc_vendor_cmd_alloc_reply_skb(dev, ST_NCI_VENDOR_OUI,
                                        HCI_DM_VDC_VALUE_COMPARISON, skb->len);
@@ -318,7 +314,6 @@ static int st_nci_hci_dm_vdc_value_comparison(struct nfc_dev *dev, void *data,
 
 free_skb:
        kfree_skb(skb);
-exit:
        return r;
 }