]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
tee: optee: add missing of_node_put after of_device_is_available
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sat, 23 Feb 2019 13:20:36 +0000 (14:20 +0100)
committerJens Wiklander <jens.wiklander@linaro.org>
Thu, 28 Feb 2019 09:23:04 +0000 (10:23 +0100)
Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: db878f76b9ff ("tee: optee: take DT status property into account")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/optee/core.c

index e5efce3c08e2eee08c3a3bc6fb330da07df5c4b8..947f9b28de9ed1b2f45542aec6cdf24367df3ff8 100644 (file)
@@ -699,8 +699,10 @@ static int __init optee_driver_init(void)
                return -ENODEV;
 
        np = of_find_matching_node(fw_np, optee_match);
-       if (!np || !of_device_is_available(np))
+       if (!np || !of_device_is_available(np)) {
+               of_node_put(np);
                return -ENODEV;
+       }
 
        optee = optee_probe(np);
        of_node_put(np);