]> git.proxmox.com Git - mirror_novnc.git/commitdiff
Remove rect arguments onFBUComplete callback
authorPierre Ossman <ossman@cendio.se>
Thu, 7 Sep 2017 15:16:16 +0000 (17:16 +0200)
committerPierre Ossman <ossman@cendio.se>
Fri, 22 Sep 2017 13:17:56 +0000 (15:17 +0200)
This callback is for an entire FBU, so it's not really relevant
to include info about just a single of the included rects.

core/rfb.js
tests/test.rfb.js

index caad72cefe7b142a2f8b9926f471ccd0fff5faf9..35ee62bab83e02ef85d1204e0f063f933dc84d48 100644 (file)
@@ -137,8 +137,8 @@ export default function RFB(defaults) {
         'onPasswordRequired': function () { },  // onPasswordRequired(rfb, msg): VNC password is required
         'onClipboard': function () { },         // onClipboard(rfb, text): RFB clipboard contents received
         'onBell': function () { },              // onBell(rfb): RFB Bell message received
-        'onFBUReceive': function () { },        // onFBUReceive(rfb, fbu): RFB FBU received but not yet processed
-        'onFBUComplete': function () { },       // onFBUComplete(rfb, fbu): RFB FBU received and processed
+        'onFBUReceive': function () { },        // onFBUReceive(rfb, rect): RFB FBU rect received but not yet processed
+        'onFBUComplete': function () { },       // onFBUComplete(rfb): RFB FBU received and processed
         'onFBResize': function () { },          // onFBResize(rfb, width, height): frame buffer resized
         'onDesktopName': function () { },       // onDesktopName(rfb, name): desktop name received
         'onXvpInit': function () { }            // onXvpInit(version): XVP extensions active for this connection
@@ -1409,11 +1409,7 @@ RFB.prototype = {
 
         this._display.flip();
 
-        this._onFBUComplete(this,
-                {'x': this._FBU.x, 'y': this._FBU.y,
-                 'width': this._FBU.width, 'height': this._FBU.height,
-                 'encoding': this._FBU.encoding,
-                 'encodingName': encodingName(this._FBU.encoding)});
+        this._onFBUComplete(this);
 
         return true;  // We finished this FBU
     },
index 116b4213542190cd93156b6220e3bea28c26e749..a6d4a0d073229b67ef67cc65ec6e6e2accc3dd35 100644 (file)
@@ -1335,7 +1335,6 @@ describe('Remote Frame Buffer Protocol Client', function() {
 
                 var spy = client.get_onFBUComplete();
                 expect(spy).to.have.been.calledOnce;
-                expect(spy).to.have.been.calledWith(sinon.match.any, rect_info);
             });
 
             it('should not fire onFBUComplete if we have not finished processing the update', function () {