]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
media: cobalt: select CONFIG_SND_PCM
authorArnd Bergmann <arnd@arndb.de>
Fri, 5 Jan 2018 09:44:04 +0000 (04:44 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 23 Jan 2018 13:05:01 +0000 (08:05 -0500)
The cobalt sound driver has a dependency on ALSA, but not
on the PCM helper code, so this can lead to an extremely
rare link error in randconfig builds:

ERROR: "snd_pcm_period_elapsed" [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: "_snd_pcm_stream_lock_irqsave" [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: "snd_pcm_set_ops" [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: "snd_pcm_stream_unlock_irqrestore" [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: "snd_pcm_lib_ioctl" [drivers/media/pci/cobalt/cobalt.ko] undefined!
ERROR: "snd_pcm_new" [drivers/media/pci/cobalt/cobalt.ko] undefined!

The other audio drivers select 'SND_PCM' for this, so let's
do the same.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/cobalt/Kconfig

index 70343829a125c2d18fb1bff3fc141a0863c8a704..aa35cbc0a9042a45ce2a8ebb05f830cf915ee111 100644 (file)
@@ -6,6 +6,7 @@ config VIDEO_COBALT
        depends on SND
        depends on MTD
        select I2C_ALGOBIT
+       select SND_PCM
        select VIDEO_ADV7604
        select VIDEO_ADV7511
        select VIDEO_ADV7842