]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
rtnetlink: Drop unnecessary return value from ndo_dflt_fdb_del
authorAlexander Duyck <alexander.h.duyck@intel.com>
Tue, 15 Jul 2014 22:15:20 +0000 (15:15 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Jul 2014 06:13:26 +0000 (23:13 -0700)
This change cleans up ndo_dflt_fdb_del to drop the ENOTSUPP return value since
that isn't actually returned anywhere in the code.  As a result we are able to
drop a few lines by just defaulting this to -EINVAL.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index e9918020dbc989c8521a53da9213ee780839e3a2..8d39071f32d76a41d10c5b48e06f4cf59dca1ee5 100644 (file)
@@ -2392,22 +2392,20 @@ int ndo_dflt_fdb_del(struct ndmsg *ndm,
                     struct net_device *dev,
                     const unsigned char *addr)
 {
-       int err = -EOPNOTSUPP;
+       int err = -EINVAL;
 
        /* If aging addresses are supported device will need to
         * implement its own handler for this.
         */
        if (!(ndm->ndm_state & NUD_PERMANENT)) {
                pr_info("%s: FDB only supports static addresses\n", dev->name);
-               return -EINVAL;
+               return err;
        }
 
        if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr))
                err = dev_uc_del(dev, addr);
        else if (is_multicast_ether_addr(addr))
                err = dev_mc_del(dev, addr);
-       else
-               err = -EINVAL;
 
        return err;
 }