]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 1 Oct 2021 12:34:09 +0000 (15:34 +0300)
committerRob Clark <robdclark@chromium.org>
Tue, 12 Oct 2021 00:30:54 +0000 (17:30 -0700)
This disables a lock which wasn't enabled and it does not disable
the first lock in the array.

Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211001123409.GG2283@kili
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/dsi/dsi_host.c

index e269df285136c2c9d56fd0e171e336f0f46b209b..c86b5090fae60db7bc854496fffbdb368eacadaa 100644 (file)
@@ -451,7 +451,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host)
 
        return 0;
 err:
-       for (; i > 0; i--)
+       while (--i >= 0)
                clk_disable_unprepare(msm_host->bus_clks[i]);
 
        return ret;