net: lio_core: fix potential sign-extension overflow on large shift

BugLink: https://bugs.launchpad.net/bugs/1839036
[ Upstream commit 9476274093a0e79b905f4cd6cf6d149f65e02c17 ]

Left shifting the signed int value 1 by 31 bits has undefined behaviour
and the shift amount oq_no can be as much as 63.  Fix this by using
BIT_ULL(oq_no) instead.

Addresses-Coverity: ("Bad shift operation")
Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
index 32ae63b6f20e1eb3c94291c63b7f33d83a044a94..55490b2cfd5d9b20332a7bd1f2a41ecdfe431947 100644 (file)
--- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
@@ -848,7 +848,7 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct)
 
                        if (droq->ops.poll_mode) {
                                droq->ops.napi_fn(droq);
-                               oct_priv->napi_mask |= (1 << oq_no);
+                               oct_priv->napi_mask |= BIT_ULL(oq_no);
                        } else {
                                tasklet_schedule(&oct_priv->droq_tasklet);
                        }