]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
drivers/rtc/rtc-isl1208.c: remove redundant checks
authorSachin Kamat <sachin.kamat@linaro.org>
Tue, 12 Nov 2013 23:10:26 +0000 (15:10 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 13 Nov 2013 03:09:27 +0000 (12:09 +0900)
i2c_smbus_read_byte_data() returns negative errno on failure.  Return the
value obtained from it directly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Herbert Valerio Riedel <hvr@gnu.org>
Cc: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-isl1208.c

index c016ad81767a9d1be4697c267072a124f4398fc6..5a0bf7ce103342443c0621888595217385399724 100644 (file)
@@ -144,11 +144,7 @@ isl1208_i2c_validate_client(struct i2c_client *client)
 static int
 isl1208_i2c_get_sr(struct i2c_client *client)
 {
-       int sr = i2c_smbus_read_byte_data(client, ISL1208_REG_SR);
-       if (sr < 0)
-               return -EIO;
-
-       return sr;
+       return i2c_smbus_read_byte_data(client, ISL1208_REG_SR);
 }
 
 static int