]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
clk: imx: off by one in imx_lpcg_parse_clks_from_dt()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 28 Feb 2022 07:50:14 +0000 (10:50 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 09:58:07 +0000 (11:58 +0200)
BugLink: https://bugs.launchpad.net/bugs/1969110
[ Upstream commit 135efc3a76d127691afaf1864e4ab627bf09d53d ]

The > needs to be >= to prevent an off by one access.

Fixes: d5f1e6a2bb61 ("clk: imx: imx8qxp-lpcg: add parsing clocks from device tree")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
Link: https://lore.kernel.org/r/20220228075014.GD13685@kili
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 4b8a71f206c94445317179b79d7f91996f40dcfc)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/clk/imx/clk-imx8qxp-lpcg.c

index b23758083ce52d37d74393a24bc213a4e5ac23de..5e31a6a24b3a3cc8cc080dfd87d821c010638d7a 100644 (file)
@@ -248,7 +248,7 @@ static int imx_lpcg_parse_clks_from_dt(struct platform_device *pdev,
 
        for (i = 0; i < count; i++) {
                idx = bit_offset[i] / 4;
-               if (idx > IMX_LPCG_MAX_CLKS) {
+               if (idx >= IMX_LPCG_MAX_CLKS) {
                        dev_warn(&pdev->dev, "invalid bit offset of clock %d\n",
                                 i);
                        ret = -EINVAL;