]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/i915: Remove superfluous wait_for_error() from throttle-ioctl
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 28 Oct 2016 12:58:26 +0000 (13:58 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 28 Oct 2016 19:53:42 +0000 (20:53 +0100)
The throttle-ioctl never touches the struct_mutex. It does, however, as
part of its ABI report whether the hardware is terminally wedged. For
that purposes, it only has to report the current state and not incur the
cost of checking/waiting every invocation, as we do not have to wait for
a reset before waiting on a request to ensure completion (that is baked
into the wait request implementation).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161028125858.23563-3-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem.c

index 0c186b75ec8611bd922ce2111d7dd653165dde96..1254143ab121ed3b5db977b2363965e3146a0ac1 100644 (file)
@@ -3705,10 +3705,6 @@ i915_gem_ring_throttle(struct drm_device *dev, struct drm_file *file)
        struct drm_i915_gem_request *request, *target = NULL;
        int ret;
 
-       ret = i915_gem_wait_for_error(&dev_priv->gpu_error);
-       if (ret)
-               return ret;
-
        /* ABI: return -EIO if already wedged */
        if (i915_terminally_wedged(&dev_priv->gpu_error))
                return -EIO;