]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commitdiff
flow_dissect: call init_default_flow_dissectors() earlier
authorEric Dumazet <edumazet@google.com>
Tue, 22 Nov 2016 19:17:30 +0000 (11:17 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Nov 2016 19:44:01 +0000 (14:44 -0500)
Andre Noll reported panics after my recent fix (commit 34fad54c2537
"net: __skb_flow_dissect() must cap its return value")

After some more headaches, Alexander root caused the problem to
init_default_flow_dissectors() being called too late, in case
a network driver like IGB is not a module and receives DHCP message
very early.

Fix is to call init_default_flow_dissectors() much earlier,
as it is a core infrastructure and does not depend on another
kernel service.

Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andre Noll <maan@tuebingen.mpg.de>
Diagnosed-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow_dissector.c

index 69e4463a4b1b196482af2ef055f62f34b848f600..c6d8207ffa7e9ec6247a608bbbfbb5fc6a1076f7 100644 (file)
@@ -1013,4 +1013,4 @@ static int __init init_default_flow_dissectors(void)
        return 0;
 }
 
-late_initcall_sync(init_default_flow_dissectors);
+core_initcall(init_default_flow_dissectors);