]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
memory: omap-gpmc: add error message if bank-width property is absent
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 25 May 2017 20:07:13 +0000 (22:07 +0200)
committerTony Lindgren <tony@atomide.com>
Wed, 31 May 2017 17:08:10 +0000 (10:08 -0700)
Instead of failing silently log a hint for the dt author about the
reason of the failure.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/memory/omap-gpmc.c

index 44b79db20021d845881d268d45019c72aadceff8..2a46e6fd7d47cc0acd76d136947b511b5d4676ae 100644 (file)
@@ -2083,8 +2083,11 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
        } else {
                ret = of_property_read_u32(child, "bank-width",
                                           &gpmc_s.device_width);
-               if (ret < 0)
+               if (ret < 0) {
+                       dev_err(&pdev->dev, "%s has no 'bank-width' property\n",
+                               child->full_name);
                        goto err;
+               }
        }
 
        /* Reserve wait pin if it is required and valid */