]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
crypto: omap-sham - Fix PM reference leak in omap sham ops
authorZhang Qilong <zhangqilong3@huawei.com>
Tue, 1 Jun 2021 14:51:18 +0000 (22:51 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 11 Jun 2021 07:03:29 +0000 (15:03 +0800)
pm_runtime_get_sync will increment pm usage counter
even it failed. Forgetting to putting operation will
result in reference leak here. We fix it by replacing
it with pm_runtime_resume_and_get to keep usage counter
balanced.

Fixes: 604c31039dae4 ("crypto: omap-sham - Check for return value from pm_runtime_get_sync")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-sham.c

index ae0d320d3c60d5f0a32c9f602200b27c486b810f..dd53ad9987b0dabd14f0da8a24facdfa7d6a8179 100644 (file)
@@ -372,7 +372,7 @@ static int omap_sham_hw_init(struct omap_sham_dev *dd)
 {
        int err;
 
-       err = pm_runtime_get_sync(dd->dev);
+       err = pm_runtime_resume_and_get(dd->dev);
        if (err < 0) {
                dev_err(dd->dev, "failed to get sync: %d\n", err);
                return err;
@@ -2244,7 +2244,7 @@ static int omap_sham_suspend(struct device *dev)
 
 static int omap_sham_resume(struct device *dev)
 {
-       int err = pm_runtime_get_sync(dev);
+       int err = pm_runtime_resume_and_get(dev);
        if (err < 0) {
                dev_err(dev, "failed to get sync: %d\n", err);
                return err;