]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
media: atomisp: get rid of a warning
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 12 Apr 2018 09:44:33 +0000 (05:44 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 17 Apr 2018 09:50:04 +0000 (05:50 -0400)
On smatch, this warning is trigged:

drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c:324 __bo_take_off_handling() error: we previously assumed 'bo->prev' could be null (see line 314)

Because it can't properly analize the truth table for the above
function. So, add an explicit check for the final condition there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c

index c888f9c809f9441f3ea566f623b4aeb15a4c972d..a6620d2c9f507cf71d03cbf6a4480d3dab28b7a3 100644 (file)
@@ -319,7 +319,7 @@ static void __bo_take_off_handling(struct hmm_buffer_object *bo)
         *      to take off this bo, we just set take the "prev/next" pointers
         *      to NULL, the free rbtree stays unchaged
         */
-       } else {
+       } else if (bo->prev != NULL && bo->next != NULL) {
                bo->next->prev = bo->prev;
                bo->prev->next = bo->next;
                bo->next = NULL;