]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
qlcnic: Fix panic while setting VF's MAC address
authorManish Chopra <manish.chopra@qlogic.com>
Fri, 19 Jul 2013 20:56:30 +0000 (16:56 -0400)
committerDavid S. Miller <davem@davemloft.net>
Sat, 20 Jul 2013 00:08:16 +0000 (17:08 -0700)
o "qlcnic_sriov" structure pointer should be accessed only
  when SR-IOV is enabled. Access this pointer after SR-IOV
  PF check.

Signed-off-by: Manish Chopra <manish.chopra@qlogic.com>
Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c

index ee0c1d307966d842d824c3ed64449690946b7d76..b9b88f3a7b51631419f27fb12f912c19b0662861 100644 (file)
@@ -1621,13 +1621,15 @@ int qlcnic_sriov_set_vf_mac(struct net_device *netdev, int vf, u8 *mac)
 {
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
        struct qlcnic_sriov *sriov = adapter->ahw->sriov;
-       int i, num_vfs = sriov->num_vfs;
+       int i, num_vfs;
        struct qlcnic_vf_info *vf_info;
        u8 *curr_mac;
 
        if (!qlcnic_sriov_pf_check(adapter))
                return -EOPNOTSUPP;
 
+       num_vfs = sriov->num_vfs;
+
        if (!is_valid_ether_addr(mac) || vf >= num_vfs)
                return -EINVAL;