]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
rtlwifi: Fix errors in descriptor manipulation
authorLarry Finger <Larry.Finger@lwfinger.net>
Thu, 6 Nov 2014 01:10:53 +0000 (19:10 -0600)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 10 Nov 2014 18:10:23 +0000 (13:10 -0500)
There are typos in the handling of the descriptor pointers where the wrong
descriptor is referenced. There is also an error in which the pointer is
incremented twice.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtlwifi/pci.c

index 116f746e7c73d1a1c8c2a6377a1c8b897afc5caf..6d2b6281e22bb70184fad413dee1239f52d46cea 100644 (file)
@@ -1375,9 +1375,9 @@ static void _rtl_pci_free_tx_ring(struct ieee80211_hw *hw,
        ring->desc = NULL;
        if (rtlpriv->use_new_trx_flow) {
                pci_free_consistent(rtlpci->pdev,
-                                   sizeof(*ring->desc) * ring->entries,
+                                   sizeof(*ring->buffer_desc) * ring->entries,
                                    ring->buffer_desc, ring->buffer_desc_dma);
-               ring->desc = NULL;
+               ring->buffer_desc = NULL;
        }
 }
 
@@ -1548,7 +1548,6 @@ int rtl_pci_reset_trx_ring(struct ieee80211_hw *hw)
                                                         true,
                                                         HW_DESC_TXBUFF_ADDR),
                                                 skb->len, PCI_DMA_TODEVICE);
-                               ring->idx = (ring->idx + 1) % ring->entries;
                                kfree_skb(skb);
                                ring->idx = (ring->idx + 1) % ring->entries;
                        }