]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
devlink: fix trace format string
authorArnd Bergmann <arnd@arndb.de>
Thu, 14 Jul 2016 09:37:29 +0000 (11:37 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Jul 2016 05:16:05 +0000 (22:16 -0700)
Including devlink.h on ARM and probably other 32-bit architectures results in
a harmless warning:

In file included from ../include/trace/define_trace.h:95:0,
                 from ../include/trace/events/devlink.h:51,
                 from ../net/core/devlink.c:30:
include/trace/events/devlink.h: In function 'trace_raw_output_devlink_hwmsg':
include/trace/events/devlink.h:42:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'size_t {aka unsigned int}' [-Werror=format=]

The correct format string for 'size_t' is %zu, not %lu, this works on all
architectures.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: e5224f0fe2ac ("devlink: add hardware messages tracing facility")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/trace/events/devlink.h

index 77dce71df42aedfb399d4dae08bae74a950643a2..09f1df228f2ce8ce060817b2f80d3a21391371a5 100644 (file)
@@ -39,7 +39,7 @@ TRACE_EVENT(devlink_hwmsg,
                __entry->len = len;
        ),
 
-       TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%lu",
+       TP_printk("bus_name=%s dev_name=%s driver_name=%s incoming=%d type=%lu buf=0x[%*phD] len=%zu",
                  __get_str(bus_name), __get_str(dev_name),
                  __get_str(driver_name), __entry->incoming, __entry->type,
                  (int) __entry->len, __get_dynamic_array(buf), __entry->len)