]> git.proxmox.com Git - qemu.git/commitdiff
QEMUFileBuffered: indicate that we're ready when the underlying file is ready
authorAvi Kivity <avi@redhat.com>
Wed, 7 Jul 2010 16:44:22 +0000 (19:44 +0300)
committerAnthony Liguori <aliguori@us.ibm.com>
Mon, 11 Oct 2010 23:20:52 +0000 (18:20 -0500)
QEMUFileBuffered stops writing when the underlying QEMUFile is not ready,
and tells its producer so.  However, when the underlying QEMUFile becomes
ready, it neglects to pass that information along, resulting in stoppage
of all data until the next tick (a tenths of a second).

Usually this doesn't matter, because most QEMUFiles used with QEMUFileBuffered
are almost always ready, but in the case of exec: migration this is not true,
due to the small pipe buffers used to connect to the target process.  The
result is very slow migration.

Fix by detecting the readiness notification and propagating it.  The detection
is a little ugly since QEMUFile overloads put_buffer() to send it, but that's
the suject for a different patch.

Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
(cherry picked from commit 5e77aaa0d7d2f4ceaa4fcaf50f3a26d5150f34a6)

buffered_file.c

index 54dc6c29ba8df67ecca75fc015d06ed7cae84cf1..a79264f451312884e79fcf9949bdb727ce34fbff 100644 (file)
@@ -156,6 +156,14 @@ static int buffered_put_buffer(void *opaque, const uint8_t *buf, int64_t pos, in
         offset = size;
     }
 
+    if (pos == 0 && size == 0) {
+        DPRINTF("file is ready\n");
+        if (s->bytes_xfer <= s->xfer_limit) {
+            DPRINTF("notifying client\n");
+            s->put_ready(s->opaque);
+        }
+    }
+
     return offset;
 }