]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ftrace: Simplify glob handling in unregister_ftrace_function_probe_func()
authorNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Tue, 16 May 2017 17:51:25 +0000 (23:21 +0530)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 18 May 2017 01:51:54 +0000 (21:51 -0400)
Handle a NULL glob properly and simplify the check.

Link: http://lkml.kernel.org/r/5df74d4ffb4721db6d5a22fa08ca031d62ead493.1494956770.git.naveen.n.rao@linux.vnet.ibm.com
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/ftrace.c

index 39dca4e86a94f0867c29aaa29b47d881eefd02e8..c35c3e67d09a05be22f350978579e7ea0f59d9fd 100644 (file)
@@ -4144,9 +4144,9 @@ unregister_ftrace_function_probe_func(char *glob, struct trace_array *tr,
        int i, ret = -ENODEV;
        int size;
 
-       if (glob && (strcmp(glob, "*") == 0 || !strlen(glob)))
+       if (!glob || !strlen(glob) || !strcmp(glob, "*"))
                func_g.search = NULL;
-       else if (glob) {
+       else {
                int not;
 
                func_g.type = filter_parse_regex(glob, strlen(glob),