]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
bpfilter: Specify the log level for the kmsg message
authorGary Lin <glin@suse.com>
Wed, 23 Jun 2021 04:09:18 +0000 (12:09 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:45:53 +0000 (09:45 +0200)
BugLink: https://bugs.launchpad.net/bugs/1938199
[ Upstream commit a196fa78a26571359740f701cf30d774eb8a72cb ]

Per the kmsg document [0], if we don't specify the log level with a
prefix "<N>" in the message string, the default log level will be
applied to the message. Since the default level could be warning(4),
this would make the log utility such as journalctl treat the message,
"Started bpfilter", as a warning. To avoid confusion, this commit
adds the prefix "<5>" to make the message always a notice.

  [0] https://www.kernel.org/doc/Documentation/ABI/testing/dev-kmsg

Fixes: 36c4357c63f3 ("net: bpfilter: print umh messages to /dev/kmsg")
Reported-by: Martin Loviska <mloviska@suse.com>
Signed-off-by: Gary Lin <glin@suse.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Dmitrii Banshchikov <me@ubique.spb.ru>
Link: https://lore.kernel.org/bpf/20210623040918.8683-1-glin@suse.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/bpfilter/main.c

index 05e1cfc1e5cd114c544e224cea28d530f70243a7..291a925462463df20df39534041c71c421aa6db1 100644 (file)
@@ -57,7 +57,7 @@ int main(void)
 {
        debug_f = fopen("/dev/kmsg", "w");
        setvbuf(debug_f, 0, _IOLBF, 0);
-       fprintf(debug_f, "Started bpfilter\n");
+       fprintf(debug_f, "<5>Started bpfilter\n");
        loop();
        fclose(debug_f);
        return 0;