]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
iwlwifi: dbg_ini: properly handle ini user trigger
authorShahar S Matityahu <shahar.s.matityahu@intel.com>
Mon, 26 Nov 2018 09:02:54 +0000 (11:02 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Tue, 29 Jan 2019 14:10:33 +0000 (16:10 +0200)
in case of a user trigger while ini is enable we change
FW_DBG_TRIGGER_USER to IWL_FW_TRIGGER_ID_USER_TRIGGER in
iwl_fw_dbg_collect and then again we attempt to do so in
_iwl_fw_error_ini_dump which causes to abort the dump.

Fix it by removing the second check in _iwl_fw_error_ini_dump.

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Fixes: 7a14c23dcdee ("iwlwifi: dbg: dump data according to the new ini TLVs")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c

index 947f282c05a9a7b722c89f2e0746e5570ea0aeca..07dc2919b0b461ab9678f9d88ce340cbdd742bee 100644 (file)
@@ -1254,10 +1254,6 @@ _iwl_fw_error_ini_dump(struct iwl_fw_runtime *fwrt,
 
        if (id == FW_DBG_TRIGGER_FW_ASSERT)
                id = IWL_FW_TRIGGER_ID_FW_ASSERT;
-       else if (id == FW_DBG_TRIGGER_USER)
-               id = IWL_FW_TRIGGER_ID_USER_TRIGGER;
-       else if (id < FW_DBG_TRIGGER_MAX)
-               return NULL;
 
        if (WARN_ON(id >= ARRAY_SIZE(fwrt->dump.active_trigs)))
                return NULL;