zfs: Fix return value on zfs_snapshot error

Returning -1 in a function with return type bool is the same as
returning true. Change to return false to indicate error properly.

Detected with cppcheck.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

diff --git a/src/lxc/storage/zfs.c b/src/lxc/storage/zfs.c
index b75708f1c1272e4f74ebc28f883ca6b8b4c978c5..fc3b32247e16cecf5a35147c25e19eb9a4ed3125 100644 (file)
--- a/src/lxc/storage/zfs.c
+++ b/src/lxc/storage/zfs.c
@@ -427,7 +427,7 @@ bool zfs_snapshot(struct lxc_conf *conf, struct lxc_storage *orig,
        if (ret < 0 || ret >= PATH_MAX) {
                ERROR("Failed to create string");
                free(snapshot);
-               return -1;
+               return false;
        }
 
        cmd_args.dataset = lxc_storage_get_path(new->src, new->type);