NFSD: prevent underflow in nfssvc_decode_writeargs()

BugLink: https://bugs.launchpad.net/bugs/1971497
commit 184416d4b98509fb4c3d8fc3d6dc1437896cc159 upstream.

Smatch complains:

	fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
	warn: no lower bound on 'args->len'

Change the type to unsigned to prevent this issue.

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

diff --git a/fs/nfsd/nfsproc.c b/fs/nfsd/nfsproc.c
index 754c763374dd5b4b0ca3e5fc0eb9aa7e42426ffb..4aca93e11af77cb7afc9f57366359ed212696416 100644 (file)
--- a/fs/nfsd/nfsproc.c
+++ b/fs/nfsd/nfsproc.c
@@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)
        unsigned long cnt = argp->len;
        unsigned int nvecs;
 
-       dprintk("nfsd: WRITE    %s %d bytes at %d\n",
+       dprintk("nfsd: WRITE    %s %u bytes at %d\n",
                SVCFH_fmt(&argp->fh),
                argp->len, argp->offset);
 

diff --git a/fs/nfsd/xdr.h b/fs/nfsd/xdr.h
index ea7cca3a64b7655bae55af6647603cdc9b51cde8..6251d8754c82b29b2c06b1c3169cb707b0a49073 100644 (file)
--- a/fs/nfsd/xdr.h
+++ b/fs/nfsd/xdr.h
@@ -33,7 +33,7 @@ struct nfsd_readargs {
 struct nfsd_writeargs {
        svc_fh                  fh;
        __u32                   offset;
-       int                     len;
+       __u32                   len;
        struct kvec             first;
 };