]> git.proxmox.com Git - grub2.git/commitdiff
arm: Align section alignment with manual relocation offset code
authorAlexander Graf <agraf@csgraf.de>
Tue, 30 Apr 2019 20:43:57 +0000 (22:43 +0200)
committerDaniel Kiper <daniel.kiper@oracle.com>
Mon, 6 May 2019 10:10:54 +0000 (12:10 +0200)
The arm relocation code has a manual special case for EFI binaries to
add the natural alignment to its own relocation awareness.

Since commit a51f953f4ee87 ("mkimage: Align efi sections on 4k
boundary") we changed that alignment from 0x400 to 0x1000 bytes. Reflect
the change in that branch that we forgot as well.

This fixes running 32bit arm grub efi binaries for me again.

Fixes: a51f953f4ee87 ("mkimage: Align efi sections on 4k boundary")
Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reported-by: Steve McIntyre <steve@einval.com>
Signed-off-by: Alexander Graf <agraf@csgraf.de>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Tested-by: Julien ROBIN <julien.robin28@free.fr>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Tested-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
util/grub-mkimagexx.c

index 470fbf4dd1e75c57c1ecbf124b00b76b4171774a..bc087c2b57f81cb05f4fa34ccc8ae6f4544086a3 100644 (file)
@@ -1137,7 +1137,7 @@ SUFFIX (relocate_addrs) (Elf_Ehdr *e, struct section_metadata *smd,
                                       (int) sym_addr, (int) sym_addr);
                       /* Data will be naturally aligned */
                       if (image_target->id == IMAGE_EFI)
-                        sym_addr += 0x400;
+                        sym_addr += GRUB_PE32_SECTION_ALIGNMENT;
                       *target = grub_host_to_target32 (grub_target_to_host32 (*target) + sym_addr);
                     }
                     break;