]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
cpufreq: powernv: Dont assume distinct pstate values for nominal and pmin
authorShilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Fri, 12 Jan 2018 07:13:53 +0000 (12:43 +0530)
committerSeth Forshee <seth.forshee@canonical.com>
Fri, 23 Feb 2018 14:26:32 +0000 (08:26 -0600)
BugLink: http://bugs.launchpad.net/bugs/1751131
commit 3fa4680b860bf48b437d6a2c039789c4abe202ae upstream.

Some OpenPOWER boxes can have same pstate values for nominal and
pmin pstates. In these boxes the current code will not initialize
'powernv_pstate_info.min' variable and result in erroneous CPU
frequency reporting. This patch fixes this problem.

Fixes: 09ca4c9b5958 (cpufreq: powernv: Replacing pstate_id with frequency table index)
Reported-by: Alvin Wang <wangat@tw.ibm.com>
Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: 4.8+ <stable@vger.kernel.org> # 4.8+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/cpufreq/powernv-cpufreq.c

index b6d7c4c98d0ab67a3d141c0cc8360d722863d388..da7fdb4b661a28150669e1cdd9a490fd2fde155c 100644 (file)
@@ -288,9 +288,9 @@ next:
 
                if (id == pstate_max)
                        powernv_pstate_info.max = i;
-               else if (id == pstate_nominal)
+               if (id == pstate_nominal)
                        powernv_pstate_info.nominal = i;
-               else if (id == pstate_min)
+               if (id == pstate_min)
                        powernv_pstate_info.min = i;
 
                if (powernv_pstate_info.wof_enabled && id == pstate_turbo) {