selinux: Implement Infiniband PKey "Access" access vector

Add a type and access vector for PKeys. Implement the ib_pkey_access
hook to check that the caller has permission to access the PKey on the
given subnet prefix. Add an interface to get the PKey SID. Walk the PKey
ocontexts to find an entry for the given subnet prefix and pkey.

Signed-off-by: Daniel Jurgens <danielj@mellanox.com>
Reviewed-by: James Morris <james.l.morris@oracle.com>
Acked-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>

diff --git a/include/linux/lsm_audit.h b/include/linux/lsm_audit.h
index e58e577117b68b4be1adb0f4f98a6a35905d3af9..0df5639a4ff430a8974ef0aa02bfd35c804d74d6 100644 (file)
--- a/include/linux/lsm_audit.h
+++ b/include/linux/lsm_audit.h
@@ -45,6 +45,11 @@ struct lsm_ioctlop_audit {
        u16 cmd;
 };
 
+struct lsm_ibpkey_audit {
+       u64     subnet_prefix;
+       u16     pkey;
+};
+
 /* Auxiliary data to use in generating the audit record. */
 struct common_audit_data {
        char type;
@@ -60,6 +65,7 @@ struct common_audit_data {
 #define LSM_AUDIT_DATA_DENTRY  10
 #define LSM_AUDIT_DATA_IOCTL_OP        11
 #define LSM_AUDIT_DATA_FILE    12
+#define LSM_AUDIT_DATA_IBPKEY  13
        union   {
                struct path path;
                struct dentry *dentry;
@@ -77,6 +83,7 @@ struct common_audit_data {
                char *kmod_name;
                struct lsm_ioctlop_audit *op;
                struct file *file;
+               struct lsm_ibpkey_audit *ibpkey;
        } u;
        /* this union contains LSM specific data */
        union {

diff --git a/security/lsm_audit.c b/security/lsm_audit.c
index 37f04dadc8d6c8f2189efbaf1b75f4b112fd6b3f..c22c99fae06a7e70d3231fbef1499b2e6389aa98 100644 (file)
--- a/security/lsm_audit.c
+++ b/security/lsm_audit.c
@@ -410,6 +410,17 @@ static void dump_common_audit_data(struct audit_buffer *ab,
                audit_log_format(ab, " kmod=");
                audit_log_untrustedstring(ab, a->u.kmod_name);
                break;
+       case LSM_AUDIT_DATA_IBPKEY: {
+               struct in6_addr sbn_pfx;
+
+               memset(&sbn_pfx.s6_addr, 0,
+                      sizeof(sbn_pfx.s6_addr));
+               memcpy(&sbn_pfx.s6_addr, &a->u.ibpkey->subnet_prefix,
+                      sizeof(a->u.ibpkey->subnet_prefix));
+               audit_log_format(ab, " pkey=0x%x subnet_prefix=%pI6c",
+                                a->u.ibpkey->pkey, &sbn_pfx);
+               break;
+       }
        } /* switch (a->type) */
 }
 

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 062b459b62bf1275794a799afe4c09644383ff05..b59255f86274195a6e493ebcf313bc4644827fd8 100644 (file)
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -6148,6 +6148,27 @@ static int selinux_key_getsecurity(struct key *key, char **_buffer)
 #endif
 
 #ifdef CONFIG_SECURITY_INFINIBAND
+static int selinux_ib_pkey_access(void *ib_sec, u64 subnet_prefix, u16 pkey_val)
+{
+       struct common_audit_data ad;
+       int err;
+       u32 sid = 0;
+       struct ib_security_struct *sec = ib_sec;
+       struct lsm_ibpkey_audit ibpkey;
+
+       err = security_ib_pkey_sid(subnet_prefix, pkey_val, &sid);
+       if (err)
+               return err;
+
+       ad.type = LSM_AUDIT_DATA_IBPKEY;
+       ibpkey.subnet_prefix = subnet_prefix;
+       ibpkey.pkey = pkey_val;
+       ad.u.ibpkey = &ibpkey;
+       return avc_has_perm(sec->sid, sid,
+                           SECCLASS_INFINIBAND_PKEY,
+                           INFINIBAND_PKEY__ACCESS, &ad);
+}
+
 static int selinux_ib_alloc_security(void **ib_sec)
 {
        struct ib_security_struct *sec;
@@ -6352,6 +6373,7 @@ static struct security_hook_list selinux_hooks[] __lsm_ro_after_init = {
        LSM_HOOK_INIT(tun_dev_attach, selinux_tun_dev_attach),
        LSM_HOOK_INIT(tun_dev_open, selinux_tun_dev_open),
 #ifdef CONFIG_SECURITY_INFINIBAND
+       LSM_HOOK_INIT(ib_pkey_access, selinux_ib_pkey_access),
        LSM_HOOK_INIT(ib_alloc_security, selinux_ib_alloc_security),
        LSM_HOOK_INIT(ib_free_security, selinux_ib_free_security),
 #endif

diff --git a/security/selinux/include/classmap.h b/security/selinux/include/classmap.h
index 3e49a78f1f4642d160baf5a318c3bffa42025b2b..0fec1c505f844830b3f1e897f00af2ca0f90e25d 100644 (file)
--- a/security/selinux/include/classmap.h
+++ b/security/selinux/include/classmap.h
@@ -231,6 +231,8 @@ struct security_class_mapping secclass_map[] = {
          { COMMON_SOCK_PERMS, NULL } },
        { "smc_socket",
          { COMMON_SOCK_PERMS, NULL } },
+       { "infiniband_pkey",
+         { "access", NULL } },
        { NULL }
   };
 

diff --git a/security/selinux/include/security.h b/security/selinux/include/security.h
index b48a462cf446b189dcfa215b1d50d0658b62c425..592c014e369c1ce2b5b11ee32216b4ca50652215 100644 (file)
--- a/security/selinux/include/security.h
+++ b/security/selinux/include/security.h
@@ -181,6 +181,8 @@ int security_get_user_sids(u32 callsid, char *username,
 
 int security_port_sid(u8 protocol, u16 port, u32 *out_sid);
 
+int security_ib_pkey_sid(u64 subnet_prefix, u16 pkey_num, u32 *out_sid);
+
 int security_netif_sid(char *name, u32 *if_sid);
 
 int security_node_sid(u16 domain, void *addr, u32 addrlen,

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 2dccba4851f8161772351f8ef05a9b38ac61bcab..02257d90adc921242d14a6462bbf9378083dcb4e 100644 (file)
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -2232,6 +2232,46 @@ out:
        return rc;
 }
 
+/**
+ * security_pkey_sid - Obtain the SID for a pkey.
+ * @subnet_prefix: Subnet Prefix
+ * @pkey_num: pkey number
+ * @out_sid: security identifier
+ */
+int security_ib_pkey_sid(u64 subnet_prefix, u16 pkey_num, u32 *out_sid)
+{
+       struct ocontext *c;
+       int rc = 0;
+
+       read_lock(&policy_rwlock);
+
+       c = policydb.ocontexts[OCON_IBPKEY];
+       while (c) {
+               if (c->u.ibpkey.low_pkey <= pkey_num &&
+                   c->u.ibpkey.high_pkey >= pkey_num &&
+                   c->u.ibpkey.subnet_prefix == subnet_prefix)
+                       break;
+
+               c = c->next;
+       }
+
+       if (c) {
+               if (!c->sid[0]) {
+                       rc = sidtab_context_to_sid(&sidtab,
+                                                  &c->context[0],
+                                                  &c->sid[0]);
+                       if (rc)
+                               goto out;
+               }
+               *out_sid = c->sid[0];
+       } else
+               *out_sid = SECINITSID_UNLABELED;
+
+out:
+       read_unlock(&policy_rwlock);
+       return rc;
+}
+
 /**
  * security_netif_sid - Obtain the SID for a network interface.
  * @name: interface name