]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
perf record: Avoid duplicate call of perf_default_config()
authorYisheng Xie <xieyisheng1@huawei.com>
Mon, 12 Mar 2018 11:25:57 +0000 (19:25 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 16 Mar 2018 16:55:58 +0000 (13:55 -0300)
We have brought perf_default_config to the very beginning at main(), so
it no need to call perf_default_config() once more for most of config in
perf-record but only for record.call-graph.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1520853957-36106-2-git-send-email-xieyisheng1@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-record.c

index b81494587120cf235c5b894a11ae81d166fdde70..d33103291b026dcbb538a4253eeec33938cc88ca 100644 (file)
@@ -1279,10 +1279,12 @@ static int perf_record_config(const char *var, const char *value, void *cb)
                        return -1;
                return 0;
        }
-       if (!strcmp(var, "record.call-graph"))
-               var = "call-graph.record-mode"; /* fall-through */
+       if (!strcmp(var, "record.call-graph")) {
+               var = "call-graph.record-mode";
+               return perf_default_config(var, value, cb);
+       }
 
-       return perf_default_config(var, value, cb);
+       return 0;
 }
 
 struct clockid_map {