]> git.proxmox.com Git - mirror_qemu.git/commitdiff
monitor: use after free in do_wav_capture()
authorIsaku Yamahata <yamahata@valinux.co.jp>
Fri, 21 Jan 2011 10:53:55 +0000 (19:53 +0900)
committerAurelien Jarno <aurelien@aurel32.net>
Tue, 25 Jan 2011 08:22:51 +0000 (09:22 +0100)
use after free in do_wav_capture() on the error path.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
monitor.c

index 0cda3dad2c7dfbd13697ff983c1339646a224d50..c5f54f46c7b4f6ad21ff930ff0debedb47d0c813 100644 (file)
--- a/monitor.c
+++ b/monitor.c
@@ -2509,8 +2509,9 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
     nchannels = has_channels ? nchannels : 2;
 
     if (wav_start_capture (s, path, freq, bits, nchannels)) {
-        monitor_printf(mon, "Faied to add wave capture\n");
+        monitor_printf(mon, "Failed to add wave capture\n");
         qemu_free (s);
+        return;
     }
     QLIST_INSERT_HEAD (&capture_head, s, entries);
 }