]> git.proxmox.com Git - mirror_iproute2.git/commitdiff
rdma: Fix representation of PortInfo CapabilityMask
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 16 Sep 2018 17:28:13 +0000 (20:28 +0300)
committerStephen Hemminger <stephen@networkplumber.org>
Mon, 17 Sep 2018 15:59:13 +0000 (08:59 -0700)
The port capability mask represents IBTA PortInfo specification,
but as it is written in description of kernel commit 2f944c0fbf58
("RDMA: Fix storage of PortInfo CapabilityMask in the kernel"),
the bit 26 was mistakenly overwritten.

The rdmatool followed it too and mislead users by presenting wrong
value. Since it never showed proper value, we update the whole
port_cap_mask to comply with IBTA and show real HW values.

Fixes: da990ab40a92 ("rdma: Add link object")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
rdma/link.c

index 7e914c870994e6f6c16356ab12d8e3f77a196e5c..7a6d4b7e356d7ee228df6921941067e41a538f08 100644 (file)
@@ -20,6 +20,7 @@ static int link_help(struct rd *rd)
 static const char *caps_to_str(uint32_t idx)
 {
 #define RDMA_PORT_FLAGS(x) \
+       x(RESERVED, 0) \
        x(SM, 1) \
        x(NOTICE, 2) \
        x(TRAP, 3) \
@@ -32,7 +33,9 @@ static const char *caps_to_str(uint32_t idx)
        x(SM_DISABLED, 10) \
        x(SYS_IMAGE_GUID, 11) \
        x(PKEY_SW_EXT_PORT_TRAP, 12) \
+       x(CABLE_INFO, 13) \
        x(EXTENDED_SPEEDS, 14) \
+       x(CAP_MASK2, 15) \
        x(CM, 16) \
        x(SNMP_TUNNEL, 17) \
        x(REINIT, 18) \
@@ -43,7 +46,12 @@ static const char *caps_to_str(uint32_t idx)
        x(BOOT_MGMT, 23) \
        x(LINK_LATENCY, 24) \
        x(CLIENT_REG, 25) \
-       x(IP_BASED_GIDS, 26)
+       x(OTHER_LOCAL_CHANGES, 26) \
+       x(LINK_SPPED_WIDTH, 27) \
+       x(VENDOR_SPECIFIC_MADS, 28) \
+       x(MULT_PKER_TRAP, 29) \
+       x(MULT_FDB, 30) \
+       x(HIERARCHY_INFO, 31)
 
        enum { RDMA_PORT_FLAGS(RDMA_BITMAP_ENUM) };
 
@@ -51,9 +59,7 @@ static const char *caps_to_str(uint32_t idx)
                rdma_port_names[] = { RDMA_PORT_FLAGS(RDMA_BITMAP_NAMES) };
        #undef RDMA_PORT_FLAGS
 
-       if (idx < ARRAY_SIZE(rdma_port_names) && rdma_port_names[idx])
-               return rdma_port_names[idx];
-       return "UNKNOWN";
+       return rdma_port_names[idx];
 }
 
 static void link_print_caps(struct rd *rd, struct nlattr **tb)