]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ptp: ptp_clockmatrix: fix is_single_shot
authorMin Li <min.li.xe@renesas.com>
Tue, 24 May 2022 14:45:01 +0000 (10:45 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 26 May 2022 04:51:32 +0000 (21:51 -0700)
is_single_shot should return false for the power_of_2 mask

Fixes: bec67592521e ("ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS support")
Signed-off-by: Min Li <min.li.xe@renesas.com>
Link: https://lore.kernel.org/r/1653403501-12621-1-git-send-email-min.li.xe@renesas.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_clockmatrix.c

index cb258e1448d553120a77e604834ecb8b92291135..c9d451bf89e2de3913c645cb2c63130112858944 100644 (file)
@@ -267,7 +267,7 @@ static int arm_tod_read_trig_sel_refclk(struct idtcm_channel *channel, u8 ref)
 static bool is_single_shot(u8 mask)
 {
        /* Treat single bit ToD masks as continuous trigger */
-       return mask <= 8 && is_power_of_2(mask);
+       return !(mask <= 8 && is_power_of_2(mask));
 }
 
 static int idtcm_extts_enable(struct idtcm_channel *channel,