fix #4364: pveceph: add confirmation dialogue for ceph installation

Displays a confirmation dialogue if the user didn't explicitly
provide a valid ceph version via the `--version` flag and if
stdout is connected to a tty.

Signed-off-by: Max Carrara <m.carrara@proxmox.com>

diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index b47f8cc192eb893569498989f427f384d46a8a12..8cff04c54407fdac1697e76be3fa765fd3ef6f41 100755 (executable)
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -176,6 +176,16 @@ __PACKAGE__->register_method ({
        } else {
            die "unsupported ceph version: $cephver";
        }
+
+       if (-t STDOUT && !$param->{version}) {
+           print "This will install Ceph " . ucfirst($cephver) . " - continue (y/N)? ";
+
+           my $answer = <STDIN>;
+           my $continue = defined($answer) && $answer =~ m/^\s*y(?:es)?\s*$/i;
+
+           die "Aborting installation as requested\n" if !$continue;
+       }
+
        PVE::Tools::file_set_contents("/etc/apt/sources.list.d/ceph.list", $repolist);
 
        my $supported_re = join('|', $supported_ceph_versions->@*);